xand/camino
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Try to improve Camino.Map.Justified.lookup performance #8

New issue
Closed
opened 2025-05-02 16:20:06 -04:00 by xand · 1 comment
xand commented 2025-05-02 16:20:06 -04:00
Owner
Copy link

In Camino.Map.Justified:

  • Change Key to something like TraceResult from Data.Map.Internal.
  • Have member record a trace of the key lookup.
  • Rewrite lookup to follow the trace recorded in Key by member.

This could avoid repeating potentially expensive comparisons each time someone calls lookup on a known key.

In `Camino.Map.Justified`: - [ ] Change `Key` to something like `TraceResult` from `Data.Map.Internal`. - [ ] Have `member` record a trace of the key lookup. - [ ] Rewrite `lookup` to follow the trace recorded in `Key` by `member`. This could avoid repeating potentially expensive comparisons each time someone calls `lookup` on a known key.
xand self-assigned this 2025-05-02 16:20:06 -04:00
xand commented 2025-05-02 16:27:28 -04:00
Author
Owner
Copy link

The main caveat I can see is that operations which change the traces in the underlying Map would render these trace-based Keys invalid.

Right now this is a non-issue as the JustMap API exposes no such operations. But it would make it much harder to add them in the future.

The main caveat I can see is that operations which change the traces in the underlying `Map` would render these trace-based `Key`s invalid. Right now this is a non-issue as the `JustMap` API exposes no such operations. But it would make it much harder to add them in the future.
xand 2025-05-14 13:37:53 -04:00
Sign in to join this conversation.
justified-map
Branches Tags
Clear current reference
main
justified-map
remove-unused-maps
dev
sparse-fromMapExact
camino-0.5
camino-0.4
flake-overlays
Clear current reference
No results found.
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
xand
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
xand/camino#8
No description provided.